feat: populate approval metadata in atlantis events#783
Merged
emmanuelmaduwuba-lyft merged 1 commit intomainfrom Apr 8, 2026
Merged
feat: populate approval metadata in atlantis events#783emmanuelmaduwuba-lyft merged 1 commit intomainfrom
emmanuelmaduwuba-lyft merged 1 commit intomainfrom
Conversation
jfernandoz
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This pull request improves the audit and workflow tracking system by adding support for capturing and propagating approval metadata (approver username and approval time) throughout the Terraform deployment workflow. This enables improved auditability of who approved a deployment and when, with these details being tracked from the plan review gate through to audit logging and notifications. Unit tests have also been updated to cover the new approval fields.
Approval metadata propagation and tracking:
ApprovedByandApprovedTimefields to job state structures (Job,JobState,AtlantisJobEvent,AuditJobRequest) and ensured these fields are set and passed through all relevant workflow components.ReviewResultstruct containing the approval status, approver username, and approval timestamp, and ensured these values are used in subsequent workflow steps and state updates.Audit logging and notification improvements:
Code cleanup:
These changes collectively improve the audit trail and accountability for infrastructure changes by making approval information first-class data throughout the workflow.