Skip to content

feat: populate approval metadata in atlantis events#783

Merged
emmanuelmaduwuba-lyft merged 1 commit intomainfrom
feature-support-approvers-metadata
Apr 8, 2026
Merged

feat: populate approval metadata in atlantis events#783
emmanuelmaduwuba-lyft merged 1 commit intomainfrom
feature-support-approvers-metadata

Conversation

@emmanuelmaduwuba-lyft
Copy link
Copy Markdown
Contributor

Context
This pull request improves the audit and workflow tracking system by adding support for capturing and propagating approval metadata (approver username and approval time) throughout the Terraform deployment workflow. This enables improved auditability of who approved a deployment and when, with these details being tracked from the plan review gate through to audit logging and notifications. Unit tests have also been updated to cover the new approval fields.

Approval metadata propagation and tracking:

  • Added ApprovedBy and ApprovedTime fields to job state structures (Job, JobState, AtlantisJobEvent, AuditJobRequest) and ensured these fields are set and passed through all relevant workflow components.
  • Updated the plan review gate to return a new ReviewResult struct containing the approval status, approver username, and approval timestamp, and ensured these values are used in subsequent workflow steps and state updates.

Audit logging and notification improvements:

  • Modified the SNS notifier and audit activity to include approver information in audit job requests and events, ensuring this metadata is logged and available for downstream consumers.)

Code cleanup:

  • Removed outdated comments and improved documentation for new and updated structures and methods. [)

These changes collectively improve the audit trail and accountability for infrastructure changes by making approval information first-class data throughout the workflow.

@emmanuelmaduwuba-lyft emmanuelmaduwuba-lyft merged commit ff1a575 into main Apr 8, 2026
3 checks passed
@emmanuelmaduwuba-lyft emmanuelmaduwuba-lyft deleted the feature-support-approvers-metadata branch April 8, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants